Design comparison
SolutionDesign
Community feedback
- @lack21Posted over 1 year ago
Great work π, but I have a suggestion!
- Replace
height: 100vh
tomin-height: 100vh
in thebody
, the difference is that, when you setheight: 100vh
to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to setmin-height: 100vh
, like this in case content is overflowing container will adjust to it!
Marked as helpful0@ola3bosunPosted over 1 year ago@lack21 Thank you very much I think i met the problem you mean when I was coding the mobile screen Thanks again
1 - Replace
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
POINTING CURSOR βοΈ:
- Looks like the component's
button
element has not a pointer, this property plays a major-role in terms of both UI & UX
- The
cursor: pointer
CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.
- In terms of UI/UX, using
cursor: pointer
helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.
- So we want to add this property to the following
button
element
button { cursor: pointer; }
- Now your component's
button
has got the pointer & you learned about this property as well
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord