@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- Looks like the component is oversized in its
height
values, But i can help you to have a better component by updating your css style rules from the following css
.main-content {
width: 50em;
height: 30em;
justify-content: center;
}
- These css rules can help to have a better structured component.
HEIGHT π:
- Use
min-height: 100vh
formain
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then themain
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then themain
will start at100vh
, if the content pushes themain
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
@KinginGuzman
Posted
Thank you very much ! I was so stuck and was getting annoyed on how it kept cutting out π . Appreciate the comment it was very helpful, thank you ! @0xAbdulKhalid
@0xabdulkhaliq
Posted
@KinginGuzman Glad you found it helpful ! π€