Result Summary Card (Self-taught, constructive criticism welcomed!)

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component is oversized in its height values, But i can help you to have a better component by updating your css style rules from the following css

  ---

  .main-content {
    width: 50em;
    height: 30em;
    justify-content: center;
  }
  

  ---

  • These css rules can help to have a better structured component.

  HEIGHT 📐:

  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  KinginGuzman•30

  @KinginGuzmanPosted over 1 year ago

  Thank you very much ! I was so stuck and was getting annoyed on how it kept cutting out 😅. Appreciate the comment it was very helpful, thank you ! @0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @KinginGuzman Glad you found it helpful ! 🤠

  0
• 

  kirty•380

  @kirtymeenaPosted over 1 year ago

  Hi,

  The UI looks good. Great job 👍.

  But it is not responsive. For a small screen, the size doesn't readjust. I would suggest you learn about media queries.

  Also, the card seems to touch the edges of the screen from the top and bottom so you can add some padding for the top and bottom.

  1

  ---

  

  KinginGuzman•30

  @KinginGuzmanPosted over 1 year ago

  Thank you ! I had trouble with the readjusting, but I been looking into some solutions. Again thank you! @kirtymeena

  1