Result summary card, responsive design

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Yahya•180

  @theeagleyahyaPosted over 1 year ago

  @0xAbdulKhalid I'm sorry to fully understand you do you mean for example if i set height: 100vh and i switch to different device which is smaller than my container than the container will be cut off? it won't have scroll? and what if i set the height of the container as a percentage will that make it fit in the body no matter how big or small the device is? I appreciate any feedback.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @theeagleyahya

  • In simple words setting the height: 100vh may result in the component being cut off on smaller screens such as mobile devices on landscape orientation

  ---

  • For additional information, you can refer this stackoverflow answer

  Hope this feedback helpful !

  0

  

  Yahya•180

  @theeagleyahyaPosted over 1 year ago

  @0xAbdulKhalid thanks, for the tip.

  0
• 

  Saad Hisham•1,750

  @Saad-HishamPosted over 1 year ago

  Awesome job! However, the size appears to be a bit small based on the design. The width is 736px and the height is 513px. If you don't have access to the sketch, you can use software like Photoshop to adjust the size and ensure it matches the design perfectly.

  1

  ---

  

  Yahya•180

  @theeagleyahyaPosted over 1 year ago

  @Saad-Hisham yes that is one thing i always struggle with the exact width and height, i will try to figure out next time, thanks.

  0