Design comparison
SolutionDesign
Solution retrospective
The CSS is very messy. It could be optimized, but i just want to complete it some how as i have just started frontend development.
Community feedback
- @sumanth-chandanaPosted over 1 year ago
Hi mate!, congrats🎉 on completing the challenge. Better take care about following points.
- Check your challenge design while you are developing your solution to it.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
- Use the
alt
(alternate text) attribute as mentioned in your Accessibility Report.alt
attribute is used for Screen readers applications. - Why does alt attribute matter? Read here.
- To avoid accessibility issues "All page content should be contained by landmarks" use code as :
<body> <main> ---your code here---- </main> <footer> </footer> </body>
(why does
<main>
matter? Read here )- For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
body{ display: flex; align-items: center; justify-content: center; height: 100%; } or
body { min-height: 100vh; display: grid; place-content: center; }
- When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code. **I hope you will find this Feedback Helpful.**
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord