Design comparison
Solution retrospective
I found doing anything in css difficult, I spent 3 hours just on the mobile design which I found out was very flawed along with my code for desktop version. I tried doing variables for the colors but when it came down to the light red, cobalt blue, etc. colors I kind of choked due to the alpha, I found out that I was adding too many parathenses while typing out hsla. My question for best practices is just how do I make cleaner code? I feel like Everything is everywhere, my html feels like its missing tags, I'm not sure if I was supposed to put classes for every single element, my css was everywhere as well felt like I was writing things just to write them and see if they worked.
Community feedback
- @javascriptor1Posted over 1 year ago
Hi Aviad ,
Here are some notes about your solution :
-
You should use IMG tag for icons instead of <embed>, which will not display the icons on the page.
-
You should import bolder versions of the design font so you can use them.
-
From the summary section, remove the background and box shadow.
For the use of classes, No - you are not supposed to use classes for each project but it's always better to use them. Classes have several advantages like Reusability where you can use the same code for more than one element/case which helps modularize your code.
Keep coding!.
0 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord