Resubmit QR Code

Community feedback

• 

  Fritz•300

  @fritzadelbertusPosted about 2 years ago

  Hello @twothreetwo. First of all, congratulations on finishing this challenge! If you still have trouble loading the image I recommend changing the src attribute of the image into something like this:

  src="./images/image-qr-code.png"

  I also recommend understanding the box model (margin, padding, border) and flexbox to create layouts.

  I hope it's helpful and happy coding!

  Marked as helpful

  1

  ---

  

  LarryTheFatCat•50

  @LarryTheFatCatPosted about 2 years ago

  @fritzadelbertus

  Never heard of the box model, but I'll start to take a look at the box model (self-taught and watched 1 video that never really described it)...

  Thank you for the helpful feedback!

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Reduce 📉 the width of you component to better match the FEM design.

  • The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Change width to max-width in your component’s container to make it responsive.

  • Change width to `max-width: 100% in your image to make it responsive.

  • Move of these properties to the Body Element. There is no reason do add CSS properties to the HTML Element.

  html {
      background-color: hsl(212, 45%, 89%);
      font-family: "Outfit", "Arial", sans-serif;
      display: grid;
      place-items: center;
      height: 100vh
  

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  0