rest-countries-api-with-color-theme-switcher using React.js

Community feedback

• 

  Benjo Quilario•1,810

  @benjoquilarioPosted over 2 years ago

  Hi! Sai Pradeepti, you did a great job on finishing this one, it looks good and response rather well.

  some suggestion to improve your code.

  • I think you need to add more route path for search only <Route path='/Search' element={<SearchResults />} /> because the page on your website contradict when searching and filtering, user can't filter the when the user still searching.
  • When searching in dark mode, dark color is only half on the screen viewport, you need add a min-height your your .app and put the background-color on class .app so that the whole viewport will have a dark color.

  Overall you did well. Keep coding and happy coding too!

  cheers, benjo

  Marked as helpful

  1

  ---

  

  Sai Pradeepti•130

  @SaiPradeeptiPosted over 2 years ago

  Thanks for the advice Benjo Quilario

  0