Rest-countries-API challenge || React Router || FeedBacks Please

Community feedback

• 

  Ay•495

  @Aycom366Posted about 3 years ago

  Hi Anurag, have not checked your code or how you set everything up but checking your solutions I observed some things.

  1. I noticed your flags do not have the same height, you can make a container and inside the container, you add the image tag inside. I.e <div> <img style={object-fit:cover,width:100%,height:100%}/> </div>

  after setting up the image, you can adjust the image based on the height of the container. you can set explicit height or max height on the container. so the image would have no option but to take up the whole container space. I don't know if you understand this?? 2. The shadow used in this project is way too much, it just too much. 3. learn to use the max-width property to set the maximum width your app should be

  Marked as helpful

  0

  ---

  

  Anurag Singh•1,265

  @exist08Posted about 3 years ago

  @Aycom366 thanks, i've been struggling for image fixing inside a div, this would definitely help me

  0
• Account deleted

  Hi,

  Nice one on completing the challenge, and trust me when I say I know it's quite tricky;

  • Firstly I have to say the report is going crazy, it has huge numbers, you have to check it out.
  • Your solution works ok, but there's a lot of things that need to be;

  1. The search box doesn't work unless you put in the exact name that you are looking for. It would definitely be better for a country to show up while I am typing.
  2. One I have used the search box, there's not going back to all of the countries, then I end up refreshing the window to get everything back to normal.
  3. The styling could also use a bit more of work.

  Nonetheless, good job on this one.

  Keep coding👍.

  0

  ---

  

  Anurag Singh•1,265

  @exist08Posted about 3 years ago

  @thulanigamtee yes i used onSubmit instead of onChange elsewise i could have made that what you're saying. My mistake :-( Altough i'll try to implement it to the best

  0