Design comparison
Solution retrospective
This was very fun to do. My only struggle was trying to make it a single-page application, which can be quite hard to do with vanilla JavaScript. I am currently learning React, so I will definitely redo it and use React router for the routing. I could have chosen the easy way (using static pages) but I decided to give myself a challenge.
Community feedback
- @CodeWithAlaminPosted about 1 year ago
Hi Somadina Amuchie,
Overall, I'm really impressed with your work! The website looks great. However, I did find a few bugs that I thought I'd mention:
- When filtering by region and then searching for a country, the search results do not filter to the selected region. Instead, all countries are returned.
- After searching for a query and opening a country's details, clicking the back button to return to the search results prevents other countries from opening.
- There is no loading indicator to show the user that the website is working in the background.
- When opening a country's details, the border countries are not shown.
Overall, I think the site is very close to completion. Fixing the above-mentioned bugs would put your JavaScript skills to the challenge, but I'm confident that you can do it! 👍
2@gHoSTeCHsPosted about 1 year ago@CodePapa360 Thanks a lot. Your feedback was really insightful. I will get to fixing the said bugs right away. But if you could take a look at the source code and tell me how performant and clean the code or should be, that would be very much appreciated. Look forward to hearing from you!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord