REST Country API using ReactJS

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Good job

  Keep up the good work

  Your solution looks great however I think that the title in the navigation bar should have a smaller font size. Secondly the name of the country in the card should be in a heavier font weight.

  In terms of your accessibility issues

  • Select element must have an accessible name, this means that it's name must not be select.

  • Heading levels should increase by one level means that if you have a h1 the preceding tag should be a h2.

  • Document should have one main landmark, this is caused by the inability to detect the main content of the page and can be fixed by wrapping all the tags between the body tag within the semantic main tag since it establishes that any enclosed tags form the main content of the page.

  Once this issue is resolved the rest of accessibility issues should be resolved

  In terms of validation issues

  • Bad value /countries/Åland Islands for attribute href on element a: Illegal character in path segment: space is not allowed. This means that you can't have a space in a path and is the cause of the rest of validation errors which once resolved will get rid of all the validation errors

  Hope this helps

  Cheers

  0

  ---

  

  Quang Hung Pham•470

  @pqhung3007Posted over 2 years ago

  @TheCoderGuru Hi Shashree! First of all thanks for the feedbacks on texting and accessibility issues. Regarding validation issue, to prevent letter spacing in query can I search countries by another property such as alphaCode? If having done this challenge, what was your approach to this problem?

  0