Design comparison
SolutionDesign
Solution retrospective
This is my solution, i was wondering how to convert an ISO alpha-3 into country names. This is what i couldn't do. Any other feedback is welcome. Thank you.
Community feedback
- @denieldenPosted about 2 years ago
Hello Mukwende, You have done a good work! 😁
To convert an ISO alpha-3 into country names you can use the alpha-3 code to select the obj and here you return name
Some little tips to improve your code:
- add
main
tag and wrap the sections of page for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - instead of using
px
use relative units of measurement likerem
-> read here - use one class to
body
to change the all theme color of app - after, add
transition
on the body to smooth the change theme color - use
ul
element for the details text of country instead of multiplep
- if I type a query that doesn't give any results, the app open a casual country, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
- in the light mode the card body remain dark
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord