REST Countries with Vanila JS and theme switcher

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Greetings, once again, Dušan! 👋

  I think you've done a very nice job on this challenge! 👏 Your solution looks good and responds well, and the themes and search and filter functionality works great! 🙌 I really like the loading animation you added before the content loads on one of the country pages (it looks very clean). 🤩

  I only suggest taking a look at your solution report and trying to clear up some of the errors that are there (since there seem to be quite a few, at the moment). 😉

  And as always, keep coding (and happy coding, too)! 😁

  1

  ---

  

  Dusan•700

  @DEmanderbagPosted over 3 years ago

  Hi, @ApplePieGiraffe

  I've noticed that there are a lot of errors especially in the HTML part of the report but I'm not sure why is that. Maybe I'm doing something bad but from what I've seen on the internet that is how you put lazy loading on the image.

  The only possible solution is to remove the loading tag in general and after that generate the new report.

  Thank you for your comment and happy coding.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @DEmanderbag

  Hmm... yeah, that's interesting. I did read that that is a way to have the browser lazy load certain images by default, and since it's like a new feature in Chrome or something, some HTML validators don't recognize it yet. 🤷‍♂️ Anyway, have fun coding, too! 👍

  1

  

  Dusan•700

  @DEmanderbagPosted over 3 years ago

  @ApplePieGiraffe

  Oh, I've just checked caniuse and for some reason, I thought lazy loading for images is much more supported. Anyway, I'm working on fixing those accessibility issues.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @DEmanderbag

  👍

  0