Rest countries with React and SASS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Joseph, You have done a good work! 😁

  Some little tips to improve your code:

  • use article tag instead of a simple div to the container card for improve the Accessibility
  • fix the descriptive text in the alt attribute of the images now return [object Object] flag
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • use ul element for the details text of country instead of multiple div
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1