REST Countries Using React JS Sass Bootstrap

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Imad, congratulations on completing the challenge 😉

  Let me give you some little tips for optimizing your code:

  • add header tag and wrap the nav to improve the Accessibility
  • use article tag for the container of cards instead of div to improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of images of flags
  • remove all margin from .country class because with flex they are superfluous... using gap property of flexbox to separate the cards
  • add transition on the body to have nice chango of dark mode
  • add background on the #user-actions .select-box .options class otherwise the filter menu isen't leggible
  • instead of using px use relative units of measurement like rem -> read here
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"

  Hope this help! Happy coding 😁

  3