REST COUNTRIES APP with theme switcher using React and SASS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Felix, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • Links must have discernible text, you can add with sr-only or hidden class
  • add main tag and wrap the cards for improve the Accessibility
  • instead of using px use relative units of measurement like rem -> read here
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Felix Castro•40

  @FelixGonzaloPosted over 2 years ago

  @denielden Thanks for the help !! 😄

  1
• 

  jay•210

  @Jay-0331Posted over 2 years ago

  Hello 👋🏻,

  For Html issue for a tags href use alpha3code for it as it is much better.

  Everything else is perfect. Great job 👍🏻

  Happy Coding🥳

  0

  ---

  

  Felix Castro•40

  @FelixGonzaloPosted over 2 years ago

  Thanks @Jay-0331 😁

  0