REST COUNTRIES APP with theme switcher

Community feedback

• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  HI, Really loved your work espcially the animation part. Tho it require some fine tunning.

  1. I think you forgot to change the color of icons(back/search) for dark mode.
  2. On detail page, there is no gap between the title and result.
  3. Caret sign on filter touches the boundry. If you could make custom filter that would be awsome(I know its hard to style the select input element)
  4. One major issue is filter and search does not work together.
  5. Create link on border country name.

  When i did my project i didnot consider what will happen if there is no border country. But not im gonna check see if it crashes in my case too .

  Overall it was a great work

  #happyCoding

  1

  ---

  

  Anthony Rosman•510

  @D3press3ddPosted over 2 years ago

  @besttlookk

  1. omg, yes i forgot that
  2. what do you mean? the nav and the country details?
  3. I will add a customize one
  4. what do you mean?
  5. i was thinking to add that later.

  Thank you for your feedback, really aprecciate

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Anthony, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • to make it look as close to the design as possible add aspect-ratio: 4/2 to the flag img and remove height
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in border countries you have to check: if there are data show them otherwise you return a string "no country"
  • border countries on click not work

  Overall you did well 😁 Hope this help!

  0

  ---

  

  Anthony Rosman•510

  @D3press3ddPosted over 2 years ago

  @denielden 1.-Oh sure, let me work in that 2.- Oh no , that looks weird is because is Link component from React Router. 3. Oh, youre right i didn't think about that 4.- A button to reset the query? 5.- i did it but instead i used "no borders founds", do you recommend to use "no country" instead? 6.- I will add that function later, i forget it

  Thank you for your feedback, that help me a lot, really aprecciate it.

  1