REST countries app with color theme switcher. SASS, REACT,REACT ROUTER

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Isaac, great work on this challenge! 😉

  Here are a few tips:

  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Isaac Novaes•650

  @isaacnovaesPosted over 2 years ago

  Hi @denielden! I really appreciate your three tips!

  The second and third ones have just been fixed.

  The first tip is kinda unclear, because I don't see any place where I used a title attribute in a link element. However, if you could show me where it is in my code, I would love to fix it too.

  Once again, thank you for revising my solution!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @isaacnovaes You are welcome! 😁

  Forgive me I explained myself badly, I meant that you used the name of the country in the link without parsing it at url:

  <Link to = { / countries / $ {countryData.name} }>

  If you try to open a country like United Kingdom and look at the browser url you will see what I mean, the url should be ... / countries / united-kingdom and not ... / countries / United% 20Kingdom

  Marked as helpful

  0

  

  Isaac Novaes•650

  @isaacnovaesPosted over 2 years ago

  @denielden Ah, now I got you. I've looked into it and I found out that this issue came up because I used the countries' names as is, i.e. with empty spaces.

  It's fixed now.

  Once again, thanks a lot!

  1