It was a great challenge, I enjoyed it. Hope you like it. Any feedback would be great!
@KaiPereira
Posted
Nice job Arsh! I love your loading animation! One small bug I found while playing around with it is when you randomly put something into the URL that is not a country code it just cycles over the loading animation forever.
Keep up the good work though!
Marked as helpful
@arshGoyalDev
Posted
@KaiPereira Thanks, Glad you like the loading animation. I will fix that bug as soon as possible.
Edit: fixed that bug
@slothmast3r
Posted
Hey Arsh! Great job!
I found a bug that when you click on Antarctica, it doesnt show anything. Prolly you didnt consider undefined parameters
Best
Marked as helpful
@arshGoyalDev
Posted
@slothmast3r Thanks for your feedback. And, I would fix that as soon as possible.
Edit: fixed the bug
@denielden
Posted
Also to optimize the code I suggest you to use a custom hook to make the API call so as to repeat less code in the various components. Read here -> docs hooks custom
Hope this help :)
Marked as helpful
@arshGoyalDev
Posted
@denielden I would read that and try to optimise the code.
@denielden
Posted
Hi Arsh, very great job!
I found a bug in the search input if you enter a keyword that doesn't give any results.
You can solve this by adding a check that in case of no result, instead of cycling the recovered data, it returns a "no result" message.
Hope this help :)
Marked as helpful
@arshGoyalDev
Posted
@denielden Thanks for your feedback. And I will definitely do that .
Edit: fixed the bug
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
