Rest Countries App

Community feedback

• 

  Kai Pereira•240

  @KaiPereiraPosted almost 3 years ago

  Nice job Arsh! I love your loading animation! One small bug I found while playing around with it is when you randomly put something into the URL that is not a country code it just cycles over the loading animation forever.

  Keep up the good work though!

  Marked as helpful

  1

  ---

  

  Arsh Goyal•940

  @arshGoyalDevPosted almost 3 years ago

  @KaiPereira Thanks, Glad you like the loading animation. I will fix that bug as soon as possible.

  Edit: fixed that bug

  0
• 

  Oskar•330

  @slothmast3rPosted almost 3 years ago

  Hey Arsh! Great job! I found a bug that when you click on Antarctica, it doesnt show anything. Prolly you didnt consider undefined parameters

  Best

  Marked as helpful

  1

  ---

  

  Arsh Goyal•940

  @arshGoyalDevPosted almost 3 years ago

  @slothmast3r Thanks for your feedback. And, I would fix that as soon as possible.

  Edit: fixed the bug

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Also to optimize the code I suggest you to use a custom hook to make the API call so as to repeat less code in the various components. Read here -> docs hooks custom

  Hope this help :)

  Marked as helpful

  1

  ---

  

  Arsh Goyal•940

  @arshGoyalDevPosted almost 3 years ago

  @denielden I would read that and try to optimise the code.

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Arsh, very great job!

  I found a bug in the search input if you enter a keyword that doesn't give any results.

  You can solve this by adding a check that in case of no result, instead of cycling the recovered data, it returns a "no result" message.

  Hope this help :)

  Marked as helpful

  1

  ---

  

  Arsh Goyal•940

  @arshGoyalDevPosted almost 3 years ago

  @denielden Thanks for your feedback. And I will definitely do that .

  Edit: fixed the bug

  0