Rest Countries API with ReactJS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Pablo, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add semantic html like header, main, button tags and wrap the relative content for improve the Accessibility
  • add descriptive text in the alt attribute of the images not simple word flag
  • to make it look as close to the design as possible set the same width of container card-container to selector container class
  • remove all margin from #card-container .card class because with flex they are superfluous and use gap property
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties
  • instead of using px use relative units of measurement like rem -> read here
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • I would also add a query reset button, I find it very convenient

  Overall you did well 😁 Hope this help!

  0

  ---

  

  Pablo Solares•160

  @PabloSolaresPosted over 2 years ago

  @denielden thanks friend I'll do it

  1