Design comparison
Solution retrospective
Hi! This is the first advanced challenge I've completed. So, I'd be more than happy to receive some feedback since I am sure there are lots of things to improve. Thanks!
Community feedback
- @PeshwariNaanPosted about 2 years ago
Hello Carla - Really well done project here, great work. The responsiveness is really smooth and the layout looks perfect.
The only suggestion I would make would be to make your code more modular to make React work to your benefit. For example, move all code for the country cards to a separate component that can be reused and import and map that component onto your homepage. This way you avoid a lot of unnecessary re-renders and it also gives you the ability to memoize your components (if needed) which will help with efficiency and can really boost up the SEO for your sites in the future. You don't really need to memoize anything in this project as it doesn't have any computationally intense functions, but creating separate components when you can is really good practice. It keeps things lean.
-Cheers
Marked as helpful0@iamcgsPosted about 2 years ago@PeshwariNaan thank you so much for taking the time to check my project out. I really appreciate it. Great suggestion! It will help me to improve for sure.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord