REST COUNTRIES API WITH REACT JS AND STYLED COMPONENTS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Pritam, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image, for example the name of country
  • instead of setting height: 30vh on the flag image I suggest you to use aspect-ratio because in my screen they are vertical and striped
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"

  Overall you did well 😉

  Hope this help and happy coding!

  0