REST Countries API with Next.js, Typescript and Tailwind

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ian, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add header tag and wrap the top bar for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the span container of flag images
  • to make all flag images the same height in all screen use the aspect-ratio: 3/2 properties instead height otherwise on a narrow screen the flags will be nearly square
  • instead of using px use relative units of measurement like rem -> read here
  • instead using p with <br> for the details of country you can use ul element
  • add a little transition on the change dark/light mode
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Overall you did well 😁 Hope this help!

  0