Travolgi 🍕• 31,420
@denielden
Posted
Hi Abdelghafour, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the cards for improve the Accessibility - to make it look as close to the design as possible add
padding-inline: 2rem
toApp
class - instead of using
px
use relative units of measurement likerem
-> read here - if you want to use the title for the
href
attribute you have to parse it inurl
, it can give problems creating links with empty spaces or special characters - I would also add a query reset button, I find it very convenient... very easy
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
- to make all flag images the same height use the
object-fit: cover
property
Overall you did well 😁 Hope this help!
Marked as helpful
1
Abdelghafour• 580
@Abdelghafour122
Posted
@denielden thank you!
1