REST Countries API with color theme switcher with React

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi JD, congratulations on completing the challenge, great job! 😁

  It is normal that it is complicated at first but do not worry with the practice you will see that everything will be simpler and more intuitive :) do not give up!

  Some little tips for optimizing your code:

  • add header tag and wrap the navabr for improve the Accessibility
  • use main tag to wrap the content of page and for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • use ul element for the details text of country instead of multiple p
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Hope this help! Happy coding 😉

  Marked as helpful

  0

  ---

  

  J.D. Browne•870

  @PeshwariNaanPosted about 2 years ago

  @denielden Thank you so much for taking the time to review my project. I'm still getting familiar with the accessibility aspects in my code so I appreciate the advice and will change the code accordingly. I had meant to put in a query reset button and then spaced it out, I definitely need to include one. I haven't had too much experience with themes and I know I have a lot of redundant code for the dark theme switch. I went through all of your code and was able to understand how you approach it and it's great and so much cleaner than my approach. I will definitely apply those principals in my next project. I see a lot of messy coding in some solutions on here so being able to see some examples with some professional coding practices is very refreshing. Definitely a huge help on a lot of levels. p.s - Your Rick and Morty page is awesome. Cheers.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @PeshwariNaan You are welcome and Thank you so much :) Keep it up JD :)

  0