REST Countries API with color theme switcher using React.js
Design comparison
Solution retrospective
Hello again,
This is the first advanced challegne that I do here, all features should be working as described in the challenge page though If I missed anything or you noticed something that could be improved please let me know :)
Also not so important but I changed the order of countries from restcountries.com so that my country is first on the list xD, If anyone wants theirs to be on the first row too then they can mention their country name in the comments, I hope I'm not breaking any UN laws by doing this :p
Community feedback
- @Underscore2Posted about 2 years ago
Hello, very good! just some tips:
- Include semantic HTML tags, they are super useful for a better SEO.
- Improve media queries
- Be careful what keys you rely on, kosovo does not have ccn3 ehehe
Marked as helpful1@justgo97Posted about 2 years agoHello @Underscore2
Thanks for the feedback! I have pushed an update:
- Included semantic HTML tags
- Done some improvements to the media query though If it still needs more improvements let me know
- Nice catch on the Kosovo issue though I'm not relying on ccn3, I'm relying on cca3 but it seems that Kosovo doesn't have an ltd (top-level domain ) so the page throws an error, should be fixed now
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord