REST Countries API with color theme switcher solution

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Kevin, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • remove all unnecessary code, the less you write the better as well as being clearer: for example the figure tag container of flag image
  • you can use ul instead multiple p tag for the details of country
  • instead using margin to Country class for separate the cards try to use gap: 3rem to .country-list class
  • instead of using px use relative units of measurement like rem -> read here
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Overall you did well 😁 Hope this help!

  1

  ---

  

  Kevin Mason•280

  @mrfinesse47Posted over 2 years ago

  @denielden thank you for the feedback, i'm ready to swear off pixels for the next project. The ul is a good idea as well for a list of details, i'm not sure why I didn't think of that. The search input can be improved as well I agree.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @mrfinesse47 You are welcome! Keep it up ;)

  1