Skip to content
Submitted 3 months ago

Rest countries api with color theme switcher master

Yejin Han (한예진)•270
@Yejin-Han
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...REST Countries API with color theme switcher
  • HTML
  • CSS
  • JS
  • API
4advanced

Design comparison

SolutionDesign

Solution retrospective

What challenges did you encounter, and how did you overcome them?

When I deploy to github pages, it showed 'Unexpected Application Error! 404 Not Found' error. To solve this problem, changed package.json and basename almost 10 times and solve it. And last time I used React was almost 1 and a half year ago, so it was hard to adapt to it.

What specific areas of your project would you like help with?

Anything you've found! Thank you :)

Community feedback

  • Teodor Jenkler•3,740
    @TedJenklerPosted 3 months ago

    Hi @Yejin-Han,

    Nice project! I really like your custom select with animation and the detailed regions. Here are a few things I noticed:

    Small Fix: The cards under the flag have no borders, which affects the user experience, especially for countries like Indonesia. Adding a light border or a slim shadow effect could improve this.

    Responsiveness: The first page looks great and is very responsive—well done with the grid. However, the selected flag section has some issues. There are several small breakpoints where things look slightly off, and larger breakpoints, like at 800px wide, where the layout breaks. This could use some attention.

    JavaScript and Framework: I noticed you used Create React App for this project. While it’s used by some, many developers find it a memory hog and compatibility problem, making it less effective as a bundler. I’d recommend using Vite instead. You can set it up with npm create vite@latest and choose your project configuration.

    Overall, great job. Hope this feedback helps!

    Best, Teodor

    Marked as helpful
    0
    Yejin Han (한예진)•270
    @Yejin-HanPosted 3 months ago

    @TedJenkler Thanks a lot! It was really helpful :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord