REST Countries Api (with React)

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted almost 2 years ago

  Hello Guilherme! Nice Work!

  I have a quick improvements for you.

  You should put side effects such as interacting with DOM outside a component rendering. For example, in your App.js, you manipulate DOM to update a class in component's rendering phase. That can lead to an unpredictable behaviour.

  A better way is either do it in a function or useEffect.

    const [darkTheme, setDarkTheme] = React.useState(false);
  
  ✅ Effects run when `darkTheme` changes 
  React.useEffect(() => {
   if (darkTheme) {
      document.body.classList.add("darkTheme");
    } else {
      document.body.classList.remove("darkTheme");
    }
  }, [ darkTheme ])
  

  I hope it helps! Cheers!

  Marked as helpful

  0

  ---

  

  Guilherme Lopes•350

  @gguilhermelopesPosted almost 2 years ago

  @fazzaamiarso nice! Thanks for the tip!

  0