Submitted over 2 years ago
REST Countries API with color theme switcher
@AouraghMohamedElAmine
Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Aouragh, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - you cn use
object-fit: cover
to the image to get them to fill their box - remove all unnecessary code, the less you write the better as well as being clearer: for example int the image
height=""
- The search not work
Overall you did well :)
Hope this help and happy coding!
0@AouraghMohamedElAminePosted over 2 years ago@denielden thank you very much for the helpful tips i will consider them to improve my skills ! PS: the search bar is working now
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord