@yanyan-alien
Posted
Hi!
Congrats on completing this!👍Cool animations on the theme switcher button and the back button! ✨Also props to you for thinking of having a back to top button on this very long site
These are some of the stuffs I noticed when browsing through your live site:
- After the user sets the page to dark mode and clicks on a particular country detail, the page will be back to light mode. Maybe you can use
localStorage.getItem()
andlocalStorage.setItem()
to store and retrieve the set theme - The sticky navigation bar doesn't occupy the whole screen width when the screen is wide (eg. 1400px)
Good luck! 🎉
Marked as helpful
@yishak621
Posted
@yanyan-alien o thanks for the feedback ..and also i was thinking about how to set a dark theme in the singcountry.html page if the index.html was in the dark mode ..i will use ur recommended local storage methods .....and i will fix the fixed nav bar for wider screen