Country-flag (& dark mode) app with Typescript, React and Sass
Design comparison
Solution retrospective
Hello everyone,
Here is my solution for this challenge.
If you have any advice, they will be usefull!
Thanks :-)
Community feedback
- @catherineisonlinePosted almost 2 years ago
Look cool! In the region filter instead of none, I would write all because none sounds like a filter with no regions, the ones that don't have region :D Also, when toggling the theme the icons and text aren't changing 😊
1 - @WandolePosted almost 2 years ago
Hey,
Thank for your advice about the filter. It's probably better to change the 'None' to avoid confusion.
For the 'Dark mode' text, it's in the design: the text stay the same for both theme... When I coded that part, I found it weird too but I thought about it and finally I decided to just follow the design !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord