Rest Countries Api with Color Theme Switcher

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Pedro, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • add main tag and wrap the content of page for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • to make it look as close to the design as possible set border-radius to div container of class and not directly img
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0