REST Countries API with color theme switcher

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Eason, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the main content of the page for improve the Accessibility
  • use article tag instead of a simple div to the container card of country for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  1