REST Countries API | Vue.js 3, SASS

Community feedback

• 

  Jesse Ohanugo•110

  @J-e-s-sePosted about 2 years ago

  You don't need to re-query the api. Here's a function from my solution on how to get a country name using it's abbreviation.

  const getCountryName = (a3code: string) => { const country = countries.find((c) => c.alpha3Code === a3code) return country ? country.name : '' }

  const name = getCountryName('ALB') console.log(name) // albania

  Marked as helpful

  1

  ---

  

  Eduardo•910

  @KTrick01Posted about 2 years ago

  @J-e-s-se Hi Jesse! Thanks for your feedback! I ended up using your function, but due to how I handled the fetching it was necessary to re-query the API, because my countries details component only has access to the data of the current country, not to all of the countries, i'll change that later!

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Eduardo, congratulations on completing the challenge, very great job! 😁

  Some little tips for optimizing your code:

  • add and use inside a the article tag to the container card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the picture tag container of flag images
  • use ul element for the details text of country instead of multiple p
  • I would also add a query reset button, I find it very convenient

  Hope this help! Happy coding 😉

  Marked as helpful

  0

  ---

  

  Eduardo•910

  @KTrick01Posted about 2 years ago

  @denielden Hi! I think I applied all of your advice. Thank you for your feedback!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @KTrick01 You are welcome and keep it up 😁

  0
• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Eduardo, I tried to access the site on my desktop and also on my phone, but it's just stuck in the loading state where I can only see the header but not the content. Maybe the other commenters managed to see it, or maybe I need to try another browser? (I'm using Firefox.) In any case, I would suggest you try what @J-e-s-se mentioned, and hopefully that helps you out in displaying the full country name.

  By the way, maybe you can try the pro membership for a month and see what projects you can build? I'm on a monthly plan right now, and even though I haven't finished the free projects, I do think the pro projects are worth checking out and building.

  Anyway, hope I can see the page later!

  1

  ---

  

  Eduardo•910

  @KTrick01Posted about 2 years ago

  @elaineleung Hi Elaine! Thanks for your feedback! Actually, I always use Firefox to do the challenges so it's weird that it wasn't loading for you, but now i changed some things so i think it will work just fine now.

  0