Design comparison
SolutionDesign
Solution retrospective
please tell me how to make my code better. Thanks a lot
Community feedback
- @besttlookkPosted over 2 years ago
hi, Following are the issues I like to point out:
- Cards are not well organized. I would suggest using grid .
<div class="container"> </div>
.container{ display:grid; grid-template-columns: repeat(auto-fit, minmax(280px,1fr)) }
With above code you dont have to write media-query for differnent sceen just to style cards.
- fix the header while scrolling.
header{ position:sticky; top:0; }
- On Detail page border country name is almost toching the bottom of the screen. add some padding.
Good luck, #happyCoding
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord