REST Countries Api , using React Typescript

Community feedback

• 

  alexander•1,300

  @alex931dPosted 7 months ago

  Great solution but i notice some major flaws :)

  1. Search doesn’t work properly - when i search for example ‘ant’ all countries containing ‘ant’ no matter the order comes up usally when making an search bar you will want to check the position too
  2. React.FC is outdated and you should not use it
  3. Lack of error handling and datacontext - what i mean by that is you have no contexts where you load data from for example you chould have made an theme context and country context where you load the theme and set the theme and load the countries data from and set it you can use React’s context hook
  4. Instead of doing the loading of fetched data manually you should use something called react query since i notice you don’t take care of all edge cases, react query will do the work for you and even prioritize the fetch before the site is loaded

  Hope all of it helps :)

  Marked as helpful

  0

  ---

  

  Vinz•290

  @kamnida1992Posted 7 months ago

  @alex931d Thank you.

  0
• 

  Francisco José Valle Cornejo•210

  @C3SC0-V4113Posted 7 months ago

  Hi! Im seeing your project and is looking cool! However there are some flaws:

  • There is a scroll in the x-axis in any size of the screen, you can solve this with the css property 'overflow'
  • Your toggle theme button only works in the logo, i think is better if the letters also are clickable
  • And the search overwrites the region decision, so you have only name search or only region search, but not both combined, i solved this by doing the region by API and the name using the filter option of javascript

  1