@denielden
Posted
Hello Zaid, You have done a good work! 😁
Some little tips to improve your code:
- add
header
tag and wrap the navbar for improve the Accessibility - add
main
tag and wrap the main content of the page for improve the Accessibility - use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - instead of using
px
use relative units of measurement likerem
-> read here - use one class to
body
to change the all theme color of app - after, add
transition
on the body to smooth the change theme color - use
ul
element for the details text of country instead of multiplep
- if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
@denielden Thanks for your help. But as for the the search field if the query does not exist its supposed to show a no found component. But after I added the country details page it doesn't show again.
And for the region, there's an "All" entry to show all countries.
So can we collaborate so you could help me finish the project?
@denielden
Posted
@zaidmohammed7 You are welcome and keep it up :)
Sure, I can help you in my spare time :)