REST Countries API MultiTheme - React Tailwind

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Mohamed, You have done a good work! 😁

  Some little tips to improve your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • use article tag instead of a simple div to the container card of country for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • use ul element for the details text of country instead of multiple p
  • the descriptive page not work... I think because with react you need to set redirect to index.html
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Mohamed Sayed•290

  @msabdalaalPosted almost 2 years ago

  @denielden Hi Deniel, Thanks a lot for the feedback, I tried to fix and add pretty much everything that you told me to, and it was very helpful, I fixed the country page .. it was something regarding the react-router, and for the image part I fixed the ratio and the height and everything but using another way.. and to fix the alt issue I added a transparent-color descriptive text on the photo for accessibility, please go ahead and try it one more time and waiting for any further feedback, thx

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @msabdalaal you are welcome and keep it up :)

  1