Rest Countries API

Community feedback

• 

  Aya Saeed•1,020

  @Aya-Saeed261Posted almost 2 years ago

  Hey @JAHMD! congratulations on finishing the challenge 🎉 It looks great and there some features I'm thinking about stealing and using in my solution👀

  I have a couple of suggestions:

  • Wrap the filter button (mode button and border countries buttons as well) between button tag instead of div tags, this way it will be more semantic and also accessible by keyboard so better accessibility

  <button type="button" id="filter-btn">.</button>

  • Bad value Saint Lucia for attribute id on element div: An ID must not contain whitespace.: To fix this problem, replace whitespaces with hyphens.

  cardContainer.id = country.name.common.replaceAll(" ", "-");

  • Element p not allowed as child of element button in this context: To fix this problem, use a span tag instead of the p tag for the text in the back button.

  Hope this helps, keep it up ✌️

  Marked as helpful

  1

  ---

  

  Ahmed Wael•210

  @JAHMDPosted almost 2 years ago

  @Aya-Saeed261 Hi Aya, glad that you like it and thank you so much for your comment and for your feedback , it really helped me.

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Ahmed, You have done a good work! 😁

  Some little tips to improve your code:

  • use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images not a simple flag for all
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of flag images
  • use ul element for the details text of country instead of multiple p
  • I would also add a query reset button, I find it very convenient

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Ahmed Wael•210

  @JAHMDPosted almost 2 years ago

  @denielden Hi Deniel, thank you so much for checking my solution and for your feedback. That was helpful!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @JAHMD you are welcome and keep it up :)

  1