Rest Countries Api Finder React, React Router Dom, Styled Components
Design comparison
Solution retrospective
This one was really challenge it was my first time using styled components and my second time using react router outside of a tutorial whew I'm glad i got it all working thought if there is anything i could do to improve please let me know :) edit Does anyone know why i get these HTML errors I've checked my code for them i cant figure it out is it maybe because I'm using styled components?
Community feedback
- @shivaprakash-sudoPosted over 2 years ago
Hello Millz,
Congrats on finishing the challenge!
Everything works great, I like the cute animation before the data is loaded.😁
But there are few issues I found.
- Try to have a page title respective to the page we're visiting.
- Try to make both the icon and the text respond to the dark mode, because some people try to click on the text instead of the icon.
- Same suggestion as above for the filter option too, not everyone clicks on only the icon.
- Also, try to check your solution report, there seems to be a lot of HTML issues.
Good luck on next projects.
1@BrezusPosted over 2 years ago@shivaprakash-sudo haha thank you :D i will get to fixing those right away and yes i saw it lol all the countries used a CSS property that i guess the compiler doesn't like lol thank you for the feedback :)
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord