REST Countries API - CSS Modules + Sass

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello lissajous, You have done a good work! 😁

  Some little tips to improve your code:

  • use article tag instead of a simple div to the container cards of country for improve the Accessibility
  • instead of using px use relative units of measurement like rem -> read here
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • use ul element for the details text of country instead of multiple div
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  lissajous-laser•320

  @lissajous-laserPosted almost 2 years ago

  @denielden thanks for taking the time to review my code!

  I've implemented your tips to improve the semantic html, and I've added a 'no results' message.

  I'm still trying to figure out how to refactor the theming with the css methods that I've used in the project.

  It takes longer to use rem units when working from a mock-up, but I'll make a bigger effort to use to use them next time.

  0

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @lissajous-laser You are welcome and keep it up :)

  0