Design comparison
Solution retrospective
I'm new to react so basically it was nice learning process overall and I would like to use better method to manage state next time.
What challenges did you encounter, and how did you overcome them?Integrating data that comes from local json file when fetching fail from outside using api call was challenging for me because the object properties are different and I use separate state to mange where the data comes from .
What specific areas of your project would you like help with?Hi Everyone 👋,If you have any feedback, as React is new to me, you are welcome to share it. Thanks in advance for your time!
Community feedback
- @Mahmoud-ElagamyPosted 4 days ago
Hey, I found a few areas that could be improved:
1- 404 Error on Reload: When I reload the details page of a specific country, a 404 error occurs.
2- Region Filter Dropdown: The dropdown menu for filtering by region could be improved by automatically closing when a region is selected and highlighting the active region for better UX.
3- Search Bar Behavior: After searching for a country and clearing the input field, the results remain filtered. It would be more intuitive if clearing the input automatically reset the results to display all countries.
4- Softening Shadows: The shadows on the header, region filter button, back button, and border countries could be softened a bit for a more subtle and modern look.
5- Layout: You might want to consider using a container with a max-width to keep the content from growing indefinitely and ensure a more consistent layout on all screen sizes.
Great job overall! These small tweaks could make your app even more user-friendly.
Marked as helpful0@Girma3Posted 3 days ago@Mahmoud-Elagamy Thank you very much for your time and very helpful feedbacks, I can't believe I miss number 1 and 2 😭 and I'll improve it based on your helpful suggestions Thanks again 🙏.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord