Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Mooktar, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
header
tag and wrap the navbar for improve the Accessibility - add
main
tag and wrap the content of page for improve the Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - to make it look as close to the design as possible remove
text-align: center
fromApp
class - use
h2
element for the title/name of country not a simplep
- use
ul
element for the details text of country instead of multiplep
- if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
Overall you did well 😁 Hope this help!
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord