Travolgi 🍕• 31,420
@denielden
Posted
Hi Zibah, great work on this challenge! 😉
Here are a few tips for improve your code:
- use semantic html like
header, main, button
tags and wrap the relative content for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all
padding
fromdiv
card container because with flex they are superfluous and usegap
property for separate cards - if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region" (after choosing a region the select scompare)
- to make all flag images the same height use the
object-fit: cover and aspect-ratio: 3/2
properties
Overall you did well 😁 Hope this help!
Marked as helpful
0