Rest countries API

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Zibah, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • use semantic html like header, main, button tags and wrap the relative content for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all padding from div card container because with flex they are superfluous and use gap property for separate cards
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region" (after choosing a region the select scompare)
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  DevZibah•250

  @DevZibahPosted over 2 years ago

  @denielden Thanks

  1

  

  DevZibah•250

  @DevZibahPosted over 2 years ago

  @denielden In the filters, there's a back button to return to the home page

  1
• 

  Kelvin•915

  @Kl3vaPosted over 2 years ago

  Your solution looks great. You might want to start using html semantics and do away with div soup

  Marked as helpful

  0