Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Rest countries API

DevZibah 250

@DevZibah

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Solution retrospective


Your feedbacks are entertained.

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hi Zibah, great work on this challenge! 😉

Here are a few tips for improve your code:

  • use semantic html like header, main, button tags and wrap the relative content for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all padding from div card container because with flex they are superfluous and use gap property for separate cards
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region" (after choosing a region the select scompare)
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties

Overall you did well 😁 Hope this help!

Marked as helpful

0

DevZibah 250

@DevZibah

Posted

@denielden Thanks

1
DevZibah 250

@DevZibah

Posted

@denielden In the filters, there's a back button to return to the home page

1
Kelvin 915

@Kl3va

Posted

Your solution looks great. You might want to start using html semantics and do away with div soup

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord