Rest API countries

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Parvathyvd, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • use main tag for wrap the section for improve the Accessibility, leave the header tag outside it
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • check the data before passing it to the details page to avoid errors and have a blank page... like Antarctica: if any data is missing then don't show it
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • in the filters there is no way to return to all countries after choosing a region, add an entry "all region"

  Hope this help! Happy coding 😁

  Marked as helpful

  0

  ---

  

  Parvathy Vazhoor•880

  @parvathyvdPosted over 2 years ago

  @denielden

  Thanks for the detailed feedback. O will work on it.

  Thanks

  1