Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I am proud of my focus on details and finding solotions ,even if it takes me 4 hours or more . Nex time , I will focus on code aesthetics , Organization ,And writing more comments.
What specific areas of your project would you like help with?i want to make it more responsive
Community feedback
- @py-code314Posted 3 months ago
Hello,
Nice job on the project. I think it is responsive enough, although I wanna make some suggestions.
- When I zoom-in, the top part of the card is going out of view. May be you can use
min-height
instead ofheight
onbody
to prevent that h2:hover
is working buth2:focus
isn't working. I suggest you wraph2
in<a>
tag to access it with keyboard- You shouldn't apply
height
to any container with text as it leads to overflow problem when you add more text - Do not use
px
units forfont-size
as users can't increase font size in their browser. Userem
orem
depending on the context - There's an abrupt jump in size when the screen size reaches more than 390px. You might wanna make it a smooth transition
- To make it more responsive I suggest apply
max-width
to card only. Then everything in the card will adjust itself when you decrease screen width. You don't even need media query if you useclamp()
to reduce font size
All the best. Happy coding :)
Marked as helpful0@anwar-elbarryPosted 3 months ago@py-code314 thank you very much ,i have realized many things now thanks to your help ,i truly appreciate your effort and support.
0 - When I zoom-in, the top part of the card is going out of view. May be you can use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord