resposive-intro-component-width-signup-by css,html,js
Design comparison
Solution retrospective
any review will be welcomed ...
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello Manish, congrats on finishing the challenge, the layout looks pretty awesome and it seems that you got desktop and mobile design full responsive, good work!
I would like to give you some suggestions with your permission.
-
Nice work using transitions on your buttons and links, but I would recommend you to call those transition directly on the button instead of the
:hover
pseudoelement, you can notice that if you move the arrrow outside the button, it no longer gets the effect of tranistioning, thats because you are loosing the:hover
and with it, thetransition
, try calling your transition outside the:hover
and tell me how if you see the difference! -
In your 'Claim your free Trial', you are using a
p
tag, why not a button? it fits just perfectly, if you have problem with the default styles of buttons, you can remove them usingall: unset
.
Other than that your projects looks pretty great for me.
Hope my feedback helps you, if you have any questions, don't hesitate to ask me!
0@manishdevelopsPosted about 2 years agoHello David, thanks for the feedback. I have edited the code. but still some problem with the js. will try to improve in next js projects.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord