Resposive QR Code Layout with flexbox

Community feedback

• 

  Marcos Travaglini•6,210

  @BlackpachamamePosted 27 days ago

  Hey your solution is amazing! 🤩

  📌 Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="container"> to a <main class="container">
  • Use min-height and max-width, this will help the content stretch or shrink if you need to. Unlike height and width which can cause your content to be cut off on certain screens. For example, use min-height: 100vh instead of height: 100vh
  • You can apply display: block to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements
  • You forgot to add the corresponding colors to the texts

  0
• 

  Lucas•50

  @LucasOrtiz5Posted 27 days ago

  It is quite well done, the size is a little smaller than the original design and the color of the letters is not appropriate. the rest very good. The image and semantics of the HTML are correct. On the other hand, regarding the use of CSS, it is well implemented separately for each part of the letter as it should be. good job!

  0
• 

  lulungar•120

  @lulungarPosted 27 days ago

  great job!

  0