Resposive Qr Code component

Community feedback

• 

  C H A R A N 🎯•2,670

  @0xabdulPosted over 1 year ago

  Hey there well congrats on completing the Qr code component..🤩

  • A Few feedback for improve your code 📝
  • In Html :
  • the html page should be contained one main landmark so the reason Accessibility reports occurred !
  • fix the problem
  • Solution 📌
  • to clear the Accessibility reports using Sematic elements or non semantic elements
  • using non semantic elements ⚙️
  • Ex :

       <div class="bob" role="main"> 
       <img class="img" src="images\image-qr-code.png" alt="code"/> 
       <h1>Improve your front-end skills by building projects</h1> 
      <p>scan the QR code to visit frontend mentor and take your coding skills to the next level</p> 
      </div>  
   </body> 
   </html>
  

  • your code I few modifications doing for clear the Accessibility reports✓
  • you should try the code
  • Happy CodingwajeeNPC🤩

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="bob"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0