Skip to content
Submitted 3 months ago

Resposive nft preview card using flexbox and media query

Notobd•120
@Notobd
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

overall, I am proud of myself for completing this challenge.

What challenges did you encounter, and how did you overcome them?

I encountered challenges with using the @import method for fonts for my first time and got help from a mentor and friend.

What specific areas of your project would you like help with?

I would like to get feedback on the structure of my html, if it is okay semantically and my entire css.

Community feedback

  • Lance•1,580
    @IzykGitPosted 3 months ago

    Good work!

    Your HTML structure does not use semantic HTML. Semantic HTML utilizes elements such as <main>, <section>, and more. The reason why you want to use these is because they give context to the content they contain. Divs and span do not do this because they have no semantic value. Tags like divs and span should really only be reserved for styling or grouping of content that does not need context.

    In your css it is ok however I noticed that you utilized margin to try and center the card on the screen. An easy way to center the card would be to utilize the body element.

    body: {
 height: 100vh;
 display: flex;
 just-content: center;
 align-items: center;
}

    This should easily put your card in the middle of the screen!

    Keep up with the good work! :)

    Marked as helpful
    0
    Notobd•120
    @NotobdPosted 3 months ago

    @IzykGit Thanks for the feedback Lance and it is duly noted. Sorry for the late reply.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord